Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency consul to v1 #2688

Merged
merged 2 commits into from
Jan 30, 2023
Merged

fix(deps): update dependency consul to v1 #2688

merged 2 commits into from
Jan 30, 2023

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 added pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: dependencies Pull requests that update a dependency file labels Jan 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2023 •
edited
Loading

Codecov Report

Base: 82.00% // Head: 82.00% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3cd33df) compared to base (a0a4164).
Patch coverage: 82.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2688      +/-   ##
==========================================
- Coverage   82.00%   82.00%   -0.01%     
==========================================
  Files         418      419       +1     
  Lines       14974    15016      +42     
  Branches     3556     3561       +5     
==========================================
+ Hits        12280    12314      +34     
- Misses       2445     2452       +7     
- Partials      249      250       +1
Impacted Files Coverage Δ
packages/core/src/interface.ts 100.00% <ø> (ø)
packages/core/src/service/slsFunctionService.ts 93.13% <ø> (ø)
packages/core/src/service/mockService.ts 79.78% <67.85%> (-5.51%) ⬇️
packages/consul/src/configuration.ts 97.14% <100.00%> (+2.40%) ⬆️
packages/consul/src/lib/provider.ts 100.00% <100.00%> (ø)
packages/core/src/baseFramework.ts 85.77% <100.00%> (+0.25%) ⬆️
packages/core/src/decorator/common/mock.ts 100.00% <100.00%> (ø)
packages/core/src/decorator/constant.ts 100.00% <100.00%> (ø)
packages/core/src/decorator/index.ts 100.00% <100.00%> (ø)
packages/core/src/service/lifeCycleService.ts 98.46% <100.00%> (+0.12%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 merged commit 33adfbc into main Jan 30, 2023
@czy88840616 czy88840616 deleted the upgrade_consul_v1 branch January 30, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. pr: dependencies Pull requests that update a dependency file
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czy88840616 @codecov-commenter